Support for default exposes #1198
Draft
+172
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredi Raspall <[email protected]>
Extends the conversion from CRD to internal type to allow the support of default exposes. A default expose cannot contain any ip/nots or nat configuration. Signed-off-by: Fredi Raspall <[email protected]>
Since we keep at most one config, there's no need to clear intermediate collections. Also, reorganize the code so that adding validations is clearer. Signed-off-by: Fredi Raspall <[email protected]>
- Forbid prefixes 0/0 or ::/0 in ip/nat/nots/as-not's in exposes - Do not allow default exposes to have ip/nat/nots/not-as Signed-off-by: Fredi Raspall <[email protected]>
Reorganize code so that we validate the `Peering` objects collected in Vpcs instead of the undirected `VpcPeering` objects learnt from the CRD. Signed-off-by: Fredi Raspall <[email protected]>
Adds a method to return the set of prefixes that should be advertised for an expose. Signed-off-by: Fredi Raspall <[email protected]>
Adapt the logic to determine prefixes to be advertised for a given peering expose. Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
requested review from
qmonnet and
sergeymatov
and removed request for
a team and
sergeymatov
qmonnet
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultflag fabricator#1313 gets merged (?)